Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix deletion protection for Azure storage #46

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

flamarion
Copy link
Contributor

It is not possible lock the container, only Storage accounts

https://learn.microsoft.com/en-us/azure/storage/common/lock-account-resource?tabs=portal

To protect the container, broader research must determine if using an Immutability policy on a container can resolve this topic.

https://learn.microsoft.com/en-us/azure/storage/blobs/data-protection-overview

But Terraform AzureRM don't support container immutability policies yet.

hashicorp/terraform-provider-azurerm#3722

In the same issue above, there's a solution based on az_api provider that eventually can help if the solution is Immutability policy

Copy link
Contributor

@nfoucha nfoucha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have this level of protection anyway. I think it's reasonable to add a backlog item to look at the feasibility of using immutability policies on the containers/blob versions.

@flamarion flamarion merged commit 1bdbdf6 into main Feb 6, 2024
4 checks passed
@flamarion flamarion deleted the fix_deletion_protection_for_azure_storage branch February 6, 2024 16:34
@jsbroks
Copy link
Member

jsbroks commented Feb 6, 2024

This PR is included in version 2.1.4 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants