Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix warning on android #191

Merged
merged 2 commits into from
Dec 12, 2024
Merged

fix warning on android #191

merged 2 commits into from
Dec 12, 2024

Conversation

abdelaziz-mahdy
Copy link
Contributor

fixes #190

@AlexV525
Copy link
Contributor

Changing this might cause older SDKs to fail to process with the callback.

@wang-bin
Copy link
Owner

wang-bin commented Dec 12, 2024 •
edited
Loading

You can edit java by gradle like this commit, rename onSurfaceAvailable to onSurfaceCreated if flutterSdkVersionInt < 32700?

@abdelaziz-mahdy
Copy link
Contributor Author

Oh okay I will do the changes in gradle then to support older sdks too

@abdelaziz-mahdy
Copy link
Contributor Author

You can edit java by gradle like this commit, rename onSurfaceAvailable to onSurfaceCreated if flutterSdkVersionInt < 32700?

i did that, let me know if its correct

@wang-bin wang-bin merged commit a39b8c3 into wang-bin:master Dec 12, 2024
13 checks passed
@wang-bin
Copy link
Owner

thanks, it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

using flutter 3.27 i get this warning
3 participants
@abdelaziz-mahdy @AlexV525 @wang-bin