feat: PHP SPX #820
Open
feat: PHP SPX #820
+39
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bap14
reviewed
Nov 18, 2024
| @@ -7,7 +7,9 @@ loadEnvConfig "${WARDEN_ENV_PATH}" || exit $? | |||
| ## set defaults for this command which can be overridden either using exports in the user | |||
| ## profile or setting them in the .env configuration on a per-project basis | |||
| WARDEN_ENV_SHELL_COMMAND=${WARDEN_ENV_SHELL_COMMAND:-bash} | |||
| WARDEN_ENV_SHELL_CONTAINER=${WARDEN_ENV_SHELL_CONTAINER:-php-fpm} | |||
|
|
|||
| WARDEN_ENV_DEFAULT_SHELL_CONTAINER=$([ $WARDEN_PHP_SPX == 1 ] && echo "php-spx" || echo "php-fpm") | |||
There was a problem hiding this comment.
@SamJUK I don't fully agree with this. The warden shell goes to the standard php-fpm container and warden debug goes to php-debug container. To me this would seem like we could either add a flag --spx or create a new warden spx command to drop to a shell in it.
There was a problem hiding this comment.
I also prefer having warden spx command, similar to warden debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting work to make use of the new PHP SPX images introduced in wardenenv/images#17
PR for Supporting documentation: wardenenv/docs#25
Key Points:
WARDEN_PHP_SPXto toggle feature statewarden shellto automatically pick the correct container depending on the feature flag