Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we run CI in PRs as well as on main #68

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Conversation

Michael-F-Bryan
Copy link
Contributor

@Michael-F-Bryan Michael-F-Bryan commented Dec 12, 2023

Deploying on the main branch just failed because we had an outdated pnpm-lock.yaml file and PRs don't try to build the website before merging.

ERR_PNPM_OUTDATED_LOCKFILE  Cannot install with "frozen-lockfile" because pnpm-lock.yaml is not up to date with package.json

Note that in CI environments this setting is true by default. If you still need to run install in such cases, use "pnpm install --no-frozen-lockfile"

    Failure reason:
    specifiers in the lockfile ({"@headlessui/react":"^1.7.14","@heroicons/react":"^2.0.18","@theguild/remark-npm2yarn":"^0.3.0","next":"^13.0.6","nextra":"latest","nextra-theme-docs":"latest","react":"^18.2.0","react-dom":"^18.2.0","sharp":"^0.32.1","@types/node":"18.11.[10](https://github.com/wasmerio/docs.wasmer.io/actions/runs/7182385929/job/19558777220#step:8:11)","@typescript-eslint/eslint-plugin":"^5.59.5","@typescript-eslint/parser":"^5.59.5","autoprefixer":"^10.4.14","eslint":"^8.40.0","eslint-plugin-react":"^7.32.2","postcss":"^8.4.23","tailwindcss":"^3.3.2","typescript":"^4.9.3"}) don't match specs in package.json ({"@types/node":"18.[11](https://github.com/wasmerio/docs.wasmer.io/actions/runs/7182385929/job/19558777220#step:8:12).10","@typescript-eslint/eslint-plugin":"^5.59.5","@typescript-eslint/parser":"^5.59.5","autoprefixer":"^10.4.14","eslint":"^8.40.0","eslint-plugin-react":"^7.32.2","postcss":"^8.4.23","tailwindcss":"^3.3.2","typescript":"^4.9.3","@headlessui/react":"^1.7.14","@heroicons/react":"^2.0.18","next":"^[13](https://github.com/wasmerio/docs.wasmer.io/actions/runs/7182385929/job/19558777220#step:8:14).0.6","nextra":"latest","nextra-theme-docs":"latest","react":"^18.2.0","react-dom":"^18.2.0","sharp":"^0.32.1"})

I've altered the CI/CD workflow so we will always build the website, but only do the actual deployment when pushing to main. That should catch these sorts of bugs in the future.

@Michael-F-Bryan Michael-F-Bryan merged commit c86c962 into main Dec 12, 2023
1 check passed
@Michael-F-Bryan Michael-F-Bryan deleted the more-ci branch December 12, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants