Restore WasmFX changes #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[test] Add tests for packed struct fields
Spec sequential visibility for globals
Add tests checking for validation failures if the output type of br_on_cast or br_on_cast_fail is not a subtype of the input type.
Rename i31.new mnemonic to ref.i31
…ypes
Test that br_on_cast{_fail} must do a down cast
Extend soundness appendix
I had intended this to be included in WebAssembly#424, but better late than never.
When referring to the `rec` keyword, do not link to the abstract syntax that happens to have the same name. Fix suggested by @bvisness and split out from WebAssembly/gc#413. Do not link to the abstract syntax
Since a deftype is already something else outside the text format. Also fix an abbreviation to correctly use "typedef" instead of "subtype". Adapted from a fix by @bvisness in WebAssembly#413.
Fix typo in MVP.md
Test that "sideways" br_on_casts are not allowed
Remove incorrect link to abstract syntax
Rename text "deftype" to "typedef"
Add current frame
Co-authored-by: Andreas Rossberg <[email protected]>
Fix ref.null semantics
Merge with WebAssembly/spec and WebAssembly/gc
1. "array is immutable" for trying to assign values into an immutable array in validation. 2. "out of bounds array access" for trying to access out of bounds array in execution. Signed-off-by: YiYing He <[email protected]>
Signed-off-by: YiYing He <[email protected]>
[test] Unify the error message.
[test] Unify the trap message of "null function reference".
This is a quick pass over the overview document. I have added type annotations and the tag filter list on `resume_throw`. --------- Co-authored-by: Andreas Rossberg <[email protected]>
Merge with WebAssembly/spec, WebAssembly/function-references, and WebAssembly/gc
This patch (re)installs the check for continuation type well-formedness. Resolves wasmfx#17 --------- Co-authored-by: Andreas Rossberg <[email protected]>
dhil
pushed a commit
that referenced
this pull request
Jul 31, 2024
dhil
pushed a commit
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally squashed a bunch of commits. This PR restores everything to the previous state.