Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table.set for continuation tables #41

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Conversation

dhil
Copy link
Member

@dhil dhil commented Jul 31, 2024

This patch fixes the failing type check that would sometimes occur when storing a continuation reference in a table. The solution: remove the type check. We cannot recover the type of a continuation reference without tracing block types in the interpreter.

Resolves #40.

@dhil dhil merged commit 221b8f1 into wasmfx:main Aug 1, 2024
1 check passed
@dhil dhil deleted the wasmfx-contref branch August 1, 2024 10:01
dhil pushed a commit that referenced this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ContRef type soundness
1 participant