Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiple times the same fountain #154

Open
ralfhauser opened this issue Mar 31, 2019 · 10 comments
Open

multiple times the same fountain #154

ralfhauser opened this issue Mar 31, 2019 · 10 comments
Labels
0 - Backlog issues that await planning and implementation Bug https://github.com/dotnet/roslyn/wiki/Labels-used-for-issues#bugs

Comments

@ralfhauser
Copy link
Member

image
image
@ralfhauser

This comment has been minimized.

Sign in to view
@ralfhauser
Copy link
Member Author

ralfhauser commented Apr 1, 2019 •
edited by mmmatthew
Loading

  1. Please make sure fountains only appear once (in SQL, it is "distinct()" function)
    2) please make a mouse-over explaining that "no date" are not included (relates to Show all fountains if date filter value lies in future #173)
    3) if date >= now, always include all fountains (relates to Show all fountains if date filter value lies in future #173)

@mmmatthew mmmatthew mentioned this issue Apr 12, 2019
Closed
@mmmatthew mmmatthew added the 0 - Backlog issues that await planning and implementation label Apr 12, 2019
@mmmatthew
Copy link
Member

Any indication how to reproduce this bug? I was not able to...
https://beta.water-fountains.org/zurich?lang=de&queryType=byId&database=wikidata&idval=Q55170432

@mmmatthew mmmatthew added Bug https://github.com/dotnet/roslyn/wiki/Labels-used-for-issues#bugs Need More Info The issue lacks enough info to make progress on it labels Apr 12, 2019
@ralfhauser
Copy link
Member Author

steps to reproduce:
i) select city basel
ii) set date-slide to 2020
iii) in the search text, type "basi"

image

@ralfhauser
Copy link
Member Author

BTW, it also happens with a more restrictive/realistic date
image

@ralfhauser
Copy link
Member Author

Basiliken-Brunnen in Basel really has 3 distinct locations, so the root cause might be the underlying osn/wikidata data

@ralfhauser
Copy link
Member Author

But allschwilerplatz is another one
image

@ralfhauser
Copy link
Member Author

ralfhauser commented Apr 13, 2019 •
edited
Loading

see also #135 - duplicate

@ralfhauser ralfhauser mentioned this issue Apr 26, 2019
Open
@ralfhauser
Copy link
Member Author

Neptun Lucerne is another one https://beta.water-fountains.org/lucerne?lang=de&queryType=byId&database=wikidata&idval=Q29785697

@ralfhauser ralfhauser removed the Need More Info The issue lacks enough info to make progress on it label May 8, 2019
@ralfhauser
Copy link
Member Author

ralfhauser commented May 10, 2019 •
edited
Loading

Allschwiler PLatz, Basel still present 2 times (duplicate water-fountains/datablue#26, #127 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - Backlog issues that await planning and implementation Bug https://github.com/dotnet/roslyn/wiki/Labels-used-for-issues#bugs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ralfhauser @mmmatthew