Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all fountains if date filter value lies in future #173

Closed
mmmatthew opened this issue Apr 12, 2019 · 9 comments
Closed

Show all fountains if date filter value lies in future #173

mmmatthew opened this issue Apr 12, 2019 · 9 comments
Assignees
Labels
Area-Filter Feature Specification For details of a complex feature Verified The closed issue was verified by a second party and can be archived
Milestone

Comments

@mmmatthew
Copy link
Member

mmmatthew commented Apr 12, 2019

Shouldn't that be 212 of 212 ?
image

  1. please make a mouse-over explaining that "no date" are not included in filter
  2. if date >= now, always include all fountains

Originally posted by @ralfhauser in #154 (comment)

@mmmatthew mmmatthew added 0 - Backlog issues that await planning and implementation Area-Filter Feature Specification For details of a complex feature labels Apr 12, 2019
@mmmatthew mmmatthew added this to the quickfix milestone Apr 13, 2019
@mmmatthew
Copy link
Member Author

mmmatthew commented Apr 13, 2019

@ralfhauser, I do not think we should implement

if date >= now, always include all fountains

It would imply that so many fountains were built in the present year, which is false.
If we set the display condition to be some year in the future, it would imply that the date data is false, which is also misleading.

mmmatthew added a commit that referenced this issue Apr 13, 2019
@mmmatthew mmmatthew self-assigned this Apr 13, 2019
@mmmatthew
Copy link
Member Author

With the mouse-over, I think we achieve clarity and precision. If users want to see all fountains, they just deactivate the filter.

image

@mmmatthew mmmatthew added 4 - In Review ready to submit a PR for review. and removed 0 - Backlog issues that await planning and implementation labels Apr 13, 2019
@ralfhauser
Copy link
Member

It would imply that so many fountains were built in the present year, which is false.

I don't understand this and I think this statement is logically wrong

@ralfhauser
Copy link
Member

but the better approach is probably not to offer 2020 if we are not yet 2020 because this is asking for troubles

same with 2030 etc.

@ralfhauser
Copy link
Member

ralfhauser commented Apr 13, 2019

Let me refine 1)
if date == now, always include all fountains with no date or a date <= now

(this under the assumption that if someone is already creating a wikikdata item for a fountain in planning/"under construction", s/he'll at least put a date)

mmmatthew added a commit that referenced this issue Apr 13, 2019
mmmatthew added a commit that referenced this issue Apr 13, 2019
@mmmatthew
Copy link
Member Author

I see what you mean. Could you check the German pop up text?

@ralfhauser
Copy link
Member

I see what you mean. Could you check the German pop up text?

It is good. Maybe just change the order of the last 2 words
<<... und "vor" ausgewählt ist.>>

mmmatthew added a commit that referenced this issue Apr 13, 2019
@mmmatthew
Copy link
Member Author

Fixed.

@ralfhauser
Copy link
Member

if you change the year from 2020 down to 2019, the number of fountains immediately jumps from 1453 to 1001

#179 will explain this for the end-user

@ralfhauser ralfhauser added Verified The closed issue was verified by a second party and can be archived and removed 4 - In Review ready to submit a PR for review. labels Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Filter Feature Specification For details of a complex feature Verified The closed issue was verified by a second party and can be archived
Projects
None yet
Development

No branches or pull requests

2 participants