Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply minimal changes needed for PyPI installation #7

Merged
merged 6 commits into from
May 2, 2024

Conversation

lbianchi-lbl
Copy link
Contributor

  • Change watertap >= 1.0.dev0 requirement to watertap since 1.0.x not yet available on PyPI
  • Add parameter_sweep._compat module allowing to import get_solver flexibly for different WaterTAP versions

@lbianchi-lbl lbianchi-lbl marked this pull request as ready for review May 2, 2024 22:02
@lbianchi-lbl lbianchi-lbl self-assigned this May 2, 2024
Copy link

codecov bot commented May 2, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@lbianchi-lbl
Copy link
Contributor Author

The lines reported as not covered in this patch are actually being tested, but only in the CI jobs where the source is not available (and therefore coverage cannot be computed).

@lbianchi-lbl lbianchi-lbl merged commit 2ad7c08 into main May 2, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants