增加慢日志记录 #23
Open
增加慢日志记录 #23
+488
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 30, 2020 19:41
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 1 1
Lines 3 3
======================================
Misses 3 3 Continue to review full report at Codecov.
|
wayslog
requested changes
Aug 17, 2020
| @@ -268,6 +270,12 @@ impl ClusterConfig { | |||
| pub(crate) fn fetch_interval_ms(&self) -> u64 { | |||
| self.fetch_interval.unwrap_or(DEFAULT_FETCH_INTERVAL_MS) | |||
| } | |||
|
|
|||
| pub fn set_slowlog_slow_than(&mut self, value: u64) { | |||
| if self.slowlog_slow_than.is_none() { | |||
| pub cluster: String, | ||
| pub cmd: String, | ||
| pub start: String, | ||
| pub total_dur: u128, |
| } | ||
| } | ||
|
|
||
| pub fn slowlog_entry(&self, cc: Ref<ClusterConfig>) -> Option<Entry> { | ||
| let cmd = self.borrow(); |
|
|
||
| Some(Entry { | ||
| cluster: cc.name.clone(), | ||
| cmd: cmd.req.str_data(), |
There was a problem hiding this comment.
entry这里，对于过多的请求不应该copy。经常有命令变慢是因为
* 过长的命令列表
* 过长的key
* 过大的返回值
这里不管不顾全copy了之后可能造成性能的进一步下降。多利用 Bytes 的 Arc 的特性，减少copy的可能
| @@ -550,6 +665,7 @@ impl Command { | |||
| total_tracker: None, | |||
|
|
|||
| remote_tracker: None, | |||
| remote_dur: None, | |||
There was a problem hiding this comment.
let p = cParams { iInsertMax: 10, ..Default::default() }; 这样
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.