feat(AgentInfoPersistance): handles the exception in case a BeginTran…

…saction/RollBack fails in the SetGroups method
wazuh · Feb 5, 2025 · e734d9b · e734d9b
1 parent a30a427
commit e734d9b
Showing 1 changed file with 22 additions and 2 deletions.
diff --git a/src/agent/agent_info/src/agent_info_persistance.cpp b/src/agent/agent_info/src/agent_info_persistance.cpp
@@ -230,7 +230,18 @@ bool AgentInfoPersistance::SetUUID(const std::string& uuid)
 
 bool AgentInfoPersistance::SetGroups(const std::vector<std::string>& groupList)
 {
-    auto transaction = m_db->BeginTransaction();
+    TransactionId transaction = 0;
+
+    // Handle the exception separately since it would not be necessary to perform RollBack.
+    try
+    {
+        transaction = m_db->BeginTransaction();
+    }
+    catch (const std::exception& e)
+    {
+        LogError("Failed to begin transaction: {}.", e.what());
+        return false;
+    }
 
     try
     {
@@ -247,7 +258,16 @@ bool AgentInfoPersistance::SetGroups(const std::vector<std::string>& groupList)
     catch (const std::exception& e)
     {
         LogError("Error inserting group: {}.", e.what());
-        m_db->RollbackTransaction(transaction);
+
+        try
+        {
+            m_db->RollbackTransaction(transaction);
+        }
+        catch (const std::exception& ee)
+        {
+            LogError("Rollback failed: {}.", ee.what());
+        }
+
         return false;
     }
     return true;