-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Dependency Management and Update Build Instructions #387
Comments
UpdateGoing through VCPKG documentation, testing which dependencies should be moved from a system-wide package installation to vcpkg. |
UpdateRemoved vcpkg submodule and configuration of the toolchain in CMake files. At the moment I can build the project by:
Note: the vcpkg repository still needs to be checked out, there are no packages for vcpkg, so this adds an extra step to the build process. We will have to adjust all of github actions and workflows, currently looking into: https://github.com/marketplace/actions/run-vcpkg in this regard having it as a submodule streamlines the process by a fair amount. |
UpdateUsing Made some modifications to the In a clean Ubuntu 24 I was able to build the agent installing only these packages via apt:
Trying to build packages failed since they rely on vcpkg as a submodule and have hardcoded this to enable binary caching. |
Description
The current build process has some inconsistencies in dependency management and toolchain setup that require improvement. The following issues were identified:
libmagic-dev
,libsqlite3-dev
,liblua5.4-dev
,libarchive-dev
,openssl
) are installed directly through the system package manager but are essential for the agent. These should be managed throughvcpkg
, our chosen package manager for library dependencies.vcpkg
is currently installed as a submodule of the repository. To streamline the repository and improve flexibility,vcpkg
should instead be installed as part of the external toolchain.BUILD.md
file needs updating to reflect these changes and provide clear instructions for setting up the environment and building the agent.Tasks
libmagic
,libsqlite3
,liblua5.4
,libarchive
, andopenssl
) tovcpkg
.vcpkg
as a submodule from the repository and ensure it is installed externally as part of the toolchain.BUILD.md
file.BUILD.md
file with clear and accurate instructions.Expected Outcome
vcpkg
handling all required libraries.vcpkg
submodule.The text was updated successfully, but these errors were encountered: