Refactor dependency management and update build instructions #535
+1,113
−848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jr0me
force-pushed
the
enhancement/387-refactor-dependency-management-and-update-build-instructions
branch
7 times, most recently
from
f6e8f8d to
a8e0e06
Compare
Also fixes Windows logger test after changes
Removes all sinks and inserts a stderr sink.
Status will be implemente using lock files, without asking SCM for Status
Renames unix_daemon files to instance_handler. Separates unix and Windows implementations of LockFileHandler
Changed function names to be more general and not reference any particular implementation.
Removes unused interface ilogger Adds static method to add StdErr output
RPM looks for a file called poptd on debug builds, but vcpkg generates a popt file.
RPM debug builds need a bz2d lib file, but vcpkg generates a bz2 file.
The port generated by vcpkg doesn't install a pc file for pkg config, which is used by rpm make process to find its dependencies. The files created in the portfile.cmake are based on the Dockerfiles used in package creation which similarly build and install Lua and then generate a pc file for pkg config.
The vcpkg_fixup_pkgconfig will fix absolut paths in pkg config files (.pc) There were a few of these to be fixed, but the file also tried to look for other dependencies to review and popt couldn't be found, since it's not producing a pc file under vcpkg. For this reason the offending files with absolute paths are explicitly addressed and the option SKIP_CHECK avoids the inconsistency with popt.
We need to fetch it manually before cmake configures in order to enable binary caching
Let's change it to 5.4.6 which is the one we've been using and it is also supported by this version of librpm
We need to fetch it manually before cmake configures in order to enable binary caching
jr0me
force-pushed
the
enhancement/387-refactor-dependency-management-and-update-build-instructions
branch
5 times, most recently
from
627d792 to
e968bf5
Compare
jr0me
force-pushed
the
enhancement/387-refactor-dependency-management-and-update-build-instructions
branch
from
e968bf5 to
99f32b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Tests