Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The dashboard of the mitre module is the same with or without a pinned agent #6878

Merged
merged 2 commits into from
Jul 31, 2024
Merged

The dashboard of the mitre module is the same with or without a pinned agent #6878

merged 2 commits into from
Jul 31, 2024

Conversation

chantal-kelm
Copy link
Member

@chantal-kelm chantal-kelm commented Jul 29, 2024 •
edited by Desvelao
Loading

Description

This PR fixes the MITRE ATT&CK dashboard did not change the definition when pinning/unpinning the agent.

Changes

  • Set donut type visualization

Side changes

  • Set donut type visualization (GitHub and File Integrity monitoring)

Issues Resolved

#6877

Evidence

Test

[Provide instructions to test this PR]

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@chantal-kelm chantal-kelm self-assigned this Jul 29, 2024
@chantal-kelm chantal-kelm linked an issue Jul 29, 2024 that may be closed by this pull request
The dashboard of the mitre module is the same with or without a pinned agent #6877
Closed
@chantal-kelm chantal-kelm marked this pull request as ready for review July 29, 2024 13:18
@yenienserrano
Copy link
Member

test: 🟡

image
image

It seems to me that we were changing the pie chart to donut on all dashboards to unify visualizations.

As in threat hunting:

4.9.0 threat hunting
image

4.8.1 threat hunting
image

yenienserrano
yenienserrano reviewed Jul 29, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6878 (comment)

@JuanGarriuz JuanGarriuz self-requested a review July 30, 2024 07:10
@Desvelao
Copy link
Member

Changes

  • Set donut type visualization

Side

  • Set donut type visualization (GitHub and File Integrity monitoring)

@Desvelao
Copy link
Member

🟢 # Test

image
image

Desvelao
Desvelao previously approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JuanGarriuz JuanGarriuz removed their request for review July 30, 2024 07:40
Desvelao
Desvelao previously approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Desvelao Desvelao requested a review from yenienserrano July 30, 2024 08:17
yenienserrano
yenienserrano previously approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@chantal-kelm chantal-kelm dismissed stale reviews from yenienserrano and Desvelao via ca05098 July 30, 2024 12:48
@chantal-kelm chantal-kelm force-pushed the bug/6877-the-dashboard-of-the-mitre-module-is-the-same-with-or-without-a-pinned-agent branch from 16749e3 to c85d70d Compare July 30, 2024 13:09
@chantal-kelm chantal-kelm force-pushed the bug/6877-the-dashboard-of-the-mitre-module-is-the-same-with-or-without-a-pinned-agent branch from c85d70d to 312838d Compare July 30, 2024 13:19
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.63% ( 3990 / 29267 )
Branches 9.12% ( 1746 / 19137 )
Functions 13.34% ( 943 / 7068 )
Lines 13.81% ( 3887 / 28131 )

yenienserrano
yenienserrano approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

image

Desvelao
Desvelao approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Desvelao Desvelao merged commit bfdd841 into 4.9.0 Jul 31, 2024
5 checks passed
@Desvelao Desvelao deleted the bug/6877-the-dashboard-of-the-mitre-module-is-the-same-with-or-without-a-pinned-agent branch July 31, 2024 07:15
@asteriscos asteriscos mentioned this pull request Aug 5, 2024
Closed
1 task
@asteriscos asteriscos mentioned this pull request Aug 21, 2024
Closed
74 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

@yenienserrano yenienserrano yenienserrano approved these changes

Assignees

@chantal-kelm chantal-kelm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The dashboard of the mitre module is the same with or without a pinned agent
3 participants
@chantal-kelm @yenienserrano @Desvelao