Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tooltips to new discover table call to actions #6889

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Add tooltips to new discover table call to actions #6889

merged 5 commits into from
Jul 31, 2024

Conversation

lucianogorza
Copy link
Contributor

@lucianogorza lucianogorza commented Jul 30, 2024 •
edited
Loading

Description

To improve the user experience, this PR introduces tooltips to the call-to-action links in the new Discover table. The tooltips will inform the user that clicking the link will change the context, providing a warning before any action is taken.

Issues Resolved

#6888

Evidence

image
image
image

Test

  1. Go to MITRE ATT&CK -> Events.
  2. Look for the tooltips in columns "agent.name", "rule.mitre.id" and "rule.id"

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@lucianogorza lucianogorza linked an issue Jul 30, 2024 that may be closed by this pull request
Add tooltips to new discover table call to actions #6888
Closed
1 task
@chantal-kelm chantal-kelm self-requested a review July 30, 2024 17:13
chantal-kelm
chantal-kelm previously approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
TEST: ✅

image image image

@Machi3mfl Machi3mfl self-requested a review July 31, 2024 12:04
Machi3mfl
Machi3mfl previously approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
TEST: ✅

Screen.Recording.2024-07-31.at.10.55.39.mov

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.65% ( 3994 / 29260 )
Branches 9.12% ( 1746 / 19135 )
Functions 13.34% ( 943 / 7068 )
Lines 13.83% ( 3891 / 28124 )

@asteriscos asteriscos merged commit 669f987 into 4.9.0 Jul 31, 2024
5 checks passed
@asteriscos asteriscos deleted the enhancement/6888-add-tooltips-to-new-discover-table-call-to-actions branch July 31, 2024 16:26
@asteriscos asteriscos mentioned this pull request Aug 5, 2024
Closed
1 task
@asteriscos asteriscos mentioned this pull request Aug 21, 2024
Closed
74 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Machi3mfl Machi3mfl Machi3mfl approved these changes

@chantal-kelm chantal-kelm chantal-kelm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tooltips to new discover table call to actions
4 participants
@lucianogorza @Machi3mfl @chantal-kelm @asteriscos