Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair mac deployment-agent-command #6907

Closed
wants to merge 1 commit into from

Conversation

JuanGarriuz
Copy link
Member

Description

Mac deployment-agent-command adds \n into the end of the WAZUH_REGISTRATION_PASSWORD variable. This PR removes the new line.

Issues Resolved

Evidence

image

Test

To test this PR it must be tested with a real manager.

  1. In manager files > Go to /var/ossec/etc/ossec.conf
  2. Add (in auth section) <use_password>yes</use_password>
  3. Create (in /var/ossec/etc/) authd.pass file

echo "<CUSTOM_PASSWORD>" > /var/ossec/etc/authd.pass

  1. Restart manager
  2. (In dashboard) Go to Endpoints summary > Deploy new agent. Select a mac os agent deployment.
  3. Check that '\n' doesn't show in the WAZUH_REGISTRATION_PASSWORD variable in the deployment command.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@JuanGarriuz
Copy link
Member Author

image
It was moved to 4.9.1 when this PR has uploaded

@JuanGarriuz JuanGarriuz deleted the bug/6906-fix-mac-deployment-command-agent branch August 14, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant