Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-design the Malware detection dashboard with and without a pinned agent #6980

Merged
merged 77 commits into from
Sep 20, 2024
Merged

Re-design the Malware detection dashboard with and without a pinned agent #6980

merged 77 commits into from
Sep 20, 2024

Conversation

guidomodarelli
Copy link
Contributor

@guidomodarelli guidomodarelli commented Sep 9, 2024 •
edited by asteriscos
Loading

Description

Currently, the Endpoint security > Malware detection module contains several dashboards that may be improved.
We have to analyze the alerts that will come after the changes in #6963 are completed, and re-define the visualizations implemented so they can give more accurate insights.

Issues Resolved

#6964

Evidence

Without pinned agent

malware-detection

Test

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@guidomodarelli guidomodarelli marked this pull request as draft September 9, 2024 18:29
@guidomodarelli guidomodarelli force-pushed the enhancement/6964-redesign-malware-detection-dashboard branch from 8fb8ca9 to ee74a59 Compare September 9, 2024 18:30
@guidomodarelli guidomodarelli reopened this Sep 9, 2024
@guidomodarelli
Copy link
Contributor Author

Update 2024/09/09

image
image (1)
image (2)

@guidomodarelli guidomodarelli self-assigned this Sep 9, 2024
@guidomodarelli guidomodarelli changed the base branch from master to 4.10.0 September 9, 2024 18:34
@guidomodarelli guidomodarelli linked an issue Sep 9, 2024 that may be closed by this pull request
Re-design the Malware detection dashboard with and without a pinned agent #6964
Closed
@guidomodarelli
Add Random class for generating random values
1585ec6
@guidomodarelli
Add DateFormatter class for date formatting
af33e0b
@guidomodarelli
Add NumberFormatter class with pads method
fcee264
@guidomodarelli
Add new alert generation types and configurations
b40b625
@guidomodarelli
Rename common.js to common.ts, update common data and add DECODER.- A…
592d156 
…dd type definitions for IPs, USERS, PORTS, WIN_HOSTNAMES, PATHS, AGENTS, GEO_LOCATION, and DECODER
@guidomodarelli
Add constants for alert and rule generation
c123c14
@guidomodarelli
Delete old regulatory compliance data and add new one
0348480
@guidomodarelli
Create RuleGenerator class for generating random rules
daea772
@guidomodarelli
Rename file extension to TypeScript and update script with new data t…
e2f94fb 
…ypes and structure
@guidomodarelli
Change to Typescript
3cebd1c
@guidomodarelli
Rename Random.ts to Random.js, update Random class methods. Add Yara …
5d77fc9 
…module with rule generation functionality.- Add Yara module for rule generation
@guidomodarelli
Delete unused regulatory compliance rules and modules
c672634
@guidomodarelli
Update import statements to require() in web.js file. Modifying expor…
dd971aa 
…ts to use module.exports
@guidomodarelli
Update require statements to use const and module.exports
92507e8
@guidomodarelli
Update audit data file to export variables as CommonJS
e39a02c
@guidomodarelli
Rename file from .ts to .js, update exports
0843b6c
@guidomodarelli guidomodarelli marked this pull request as ready for review September 19, 2024 16:06
@guidomodarelli
Add new dashboard panels for malware detection
c90cbb0
@guidomodarelli
Update dashboard panels UI state with column width settings
1d231c1
@guidomodarelli
Update frequency values to numeric type for alerts data
0897581
@guidomodarelli
Update instance profile ID generation with character set
f32f9d3
@guidomodarelli
Update trojans signatures to escape special characters
fdbe7f0
@guidomodarelli
Update frequency value to integer in sample data for web.js
b867d3d
@guidomodarelli
Add Random.ALPHABET to Random.createHash call in aws.js
ffa265e
@guidomodarelli
Update alert rule frequency to be a number
b8d350b
@guidomodarelli
Fix typo in loop condition length comparison
b90b70c
@guidomodarelli
Add test case for verifying unique values within length
1102857
@guidomodarelli
Add tests for rule-generator and regulatory-compliance
ce8069e
@guidomodarelli
Rename number-format.test.js to number-formatter.test.js
9268150
@guidomodarelli
Update test functions to use arrow functions
609a2da
@guidomodarelli
Update trojans signatures in policy-monitoring.js
0b487e3
@guidomodarelli
Refactor trojan signatures in policy monitoring data
da63338
@guidomodarelli
Add tests for month name formatting in DateFormatter
abb4d21
@guidomodarelli
Add sample data and update dashboard visualizations
53b5072
asteriscos
asteriscos previously approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

Without pinned agent 🟢

app-malware-detection-2024-09-20-17_02_11

With pinned agent

app-malware-detection-2024-09-20-17_06_07

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 46.02% ( 400 / 869 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.22% ( 398 / 861 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.91% ( 4122 / 29623 )
Branches 9.13% ( 1761 / 19282 )
Functions 13.64% ( 973 / 7132 )
Lines 14.1% ( 4022 / 28509 )

Tostti
Tostti approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test ✅

Without pinned agent:
image

With pinned agent:
image

CR ✅

LGTM

@asteriscos asteriscos merged commit edf5c82 into 4.10.0 Sep 20, 2024
5 checks passed
@asteriscos asteriscos deleted the enhancement/6964-redesign-malware-detection-dashboard branch September 20, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@Tostti Tostti Tostti approved these changes

Assignees

@guidomodarelli guidomodarelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-design the Malware detection dashboard with and without a pinned agent
3 participants
@guidomodarelli @asteriscos @Tostti