Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data grid pagination with relative index per page #7044

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Oct 1, 2024

Description

This pull request fixes the relative index per page. Previously the absolute result index was used and the index was not found in the page array.

Issues Resolved

#7043

Evidence

Peek 2024-10-01 18-13

Test

  • Add vulnerabilities sample data
  • Go to Vulnerabilities / Inventory
  • Change between pages
  • Verify it works and the information is consistent

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this Oct 1, 2024
@asteriscos asteriscos linked an issue Oct 1, 2024 that may be closed by this pull request
guidomodarelli
guidomodarelli previously approved these changes Oct 1, 2024
Copy link
Contributor

@guidomodarelli guidomodarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢
Test 🟢

Peek.2024-10-01.14-18.mp4

Machi3mfl
Machi3mfl previously approved these changes Oct 1, 2024
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Screen.Recording.2024-10-01.at.4.44.03.PM.mov

@asteriscos asteriscos dismissed stale reviews from Machi3mfl and guidomodarelli via 4350039 October 2, 2024 10:30
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@asteriscos asteriscos merged commit 58fd227 into 4.10.0 Oct 2, 2024
5 checks passed
@asteriscos asteriscos deleted the bug/7043-fix-data-grid-pagination branch October 2, 2024 10:33
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Main plugin code coverage (Jest) test % values
Statements 14.09% ( 4177 / 29637 )
Branches 9.18% ( 1771 / 19290 )
Functions 13.74% ( 985 / 7166 )
Lines 14.28% ( 4075 / 28523 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulnerabilities / inventory table exception in pagination
4 participants