Constrict job scheduler configuration options #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 21, 2025
f-galland
changed the base branch from
180-command-manager-config-file
to
enhancement/180-command-manager-configuration
…/223-job.schedule-negative-int-triggers-infinite-loop Signed-off-by: Fede Galland <[email protected]>
AlexRuiz7
reviewed
Jan 22, 2025
plugins/command-manager/src/main/java/com/wazuh/commandmanager/settings/PluginSettings.java
Outdated
Show resolved
Hide resolved
AlexRuiz7
reviewed
Jan 22, 2025
plugins/command-manager/src/main/java/com/wazuh/commandmanager/settings/PluginSettings.java
Outdated
Show resolved
Hide resolved
AlexRuiz7
merged commit 0f69aac
into
enhancement/180-command-manager-configuration
1 check passed
AlexRuiz7
deleted the
bug/223-job.schedule-negative-int-triggers-infinite-loop
branch
AlexRuiz7
added a commit
that referenced
this pull request
Jan 23, 2025
* Implement plugin settings class to handle command manager configuration * Initialize settings on main Command Manager class Add logs to track settings values * Make PluginSetting singleton thread-safe adding syncrhonization * Replace constants usage with PluginSettings corresponding getters * Register settings in CommandManager main class * Add logs to validate settings registering * Implement RealoadablePlugin interface to CommandManager plugin * Apply spotless formatting Set Job index as constant inside main CommandManager plugin class * Replace setting job.index.name for a constant * Apply getter functions for job index name and job type Replace constants usage with getters * Add unit tests for PluginSettings class * Add docstrings to PluginSettings functions * Remove unnecesary debug logs * Convert indexes, templates, and API URI related configuration fields to constants * Update tests with new constant values * Rename timeout setting to client.timeout for clearer naming * Update docstrings * Make constant settings static Remove plugin-scurity.policy file as it is no longer needed * Log settings on plugin's start (#235) * Constrict job scheduler configuration options (#236) * Set min and max values for settings and validate their coherence * Roll back to Setting.Property.NodeScope to fix issues * Make pit keepalive equal to job schedule in seconds * Make pit keepalive equal to job schedule in seconds * Fix tests * Refactor validateSettings() --------- Signed-off-by: Fede Galland <[email protected]> Co-authored-by: Alex Ruiz <[email protected]> * Fix import * Fix old configuration references * Remove volatile from PluginSettings instance --------- Signed-off-by: Fede Galland <[email protected]> Signed-off-by: Álex Ruiz <[email protected]> Co-authored-by: Álex Ruiz <[email protected]> Co-authored-by: Fede Galland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes bugs triggered by certain combinations of values in the command manager settings.
Issues Resolved
Closes #223
Closes #224