Merge pull request #176 from wazuh/bug/175-revert-changes-in-ova-work…

…flow-to-add-support-in-stages

Fix the ova workflow for stages support and AWS instance deletion

.github/workflows/builder_OVA.yaml

@@ -216,5 +216,5 @@ jobs:
           echo "S3 sha512 OVA URI: ${s3uri}"
 
       - name: Delete allocated VM
-        if: always() && steps.alloc_vm == 'success'
+        if: always() && steps.alloc_vm.outcome == 'success'
         run: python3 wazuh-automation/deployability/modules/allocation/main.py --action delete --track-output ${{ env.ALLOCATOR_PATH }}/track.yml

CHANGELOG.md

@@ -16,6 +16,7 @@ All notable changes to this project will be documented in this file.
 
 ### Fixed
 
+- Fix the ova workflow for stages support and AWS instance deletion. ([#175](https://github.com/wazuh/wazuh-virtual-machines/pull/176))
 - Fixed the OVA workflow to add support in stages. ([#173](https://github.com/wazuh/wazuh-virtual-machines/pull/173))
 
 ### Deleted

ova/provision.sh

@@ -13,6 +13,12 @@ ASSETS_PATH="${CURRENT_PATH}/assets"
 CUSTOM_PATH="${ASSETS_PATH}/custom"
 INSTALL_ARGS="-a"
 
+if [[ "${PACKAGES_REPOSITORY}" == "dev" ]]; then
+  INSTALL_ARGS+=" -d pre-release"
+elif [[ "${PACKAGES_REPOSITORY}" == "staging" ]]; then
+  INSTALL_ARGS+=" -d staging"
+fi
+
 if [[ "${DEBUG}" = "yes" ]]; then
   INSTALL_ARGS+=" -v"
 fi

ova/workflow_assets/ova_configurer.py

@@ -28,7 +28,7 @@ def clone_repositories():
         subprocess.run(f"git clone {repo['url']} {repo['dest']}", shell=True, check=True)
 
 
-def build_wazuh_install(repo_path, wia_branch, repository):
+def build_wazuh_install(repo_path, wia_branch):
     """
     Builds the wazuh-install.sh script and moves it to /tmp
 
@@ -41,10 +41,7 @@ def build_wazuh_install(repo_path, wia_branch, repository):
     if os.path.exists(repo_path):
         os.chdir(repo_path)
         subprocess.run(f"git checkout {wia_branch}", shell=True, check=True)
-        command = "sudo bash builder.sh -i"
-        if repository in ["dev", "staging"]:
-            command += " -d"
-        subprocess.run(command, shell=True, check=True)
+        subprocess.run("sudo bash builder.sh -i", shell=True, check=True)
         if os.path.exists("wazuh-install.sh"):
             subprocess.run("sudo mv wazuh-install.sh /tmp/wazuh-install.sh", shell=True, check=True)
 
@@ -130,7 +127,7 @@ def main():
     set_hostname()
     install_git()
     clone_repositories()
-    build_wazuh_install("/home/ec2-user/wazuh-installation-assistant", args.wia_branch, args.repository)
+    build_wazuh_install("/home/ec2-user/wazuh-installation-assistant", args.wia_branch)
     run_provision_script(args.wvm_branch, args.repository, args.debug)
     create_network_config()
     clean()