Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SignGenericMulti for extended AccountProtectingMultiSigner #7

Merged
merged 6 commits into from
Sep 13, 2024
Merged

Implement SignGenericMulti for extended AccountProtectingMultiSigner #7

merged 6 commits into from
Sep 13, 2024

Conversation

Bez625
Copy link
Contributor

@Bez625 Bez625 commented Sep 11, 2024

Implement SignGenericMulti in the dirk wallet

@Bez625 Bez625 marked this pull request as ready for review September 11, 2024 13:07
mcdee
mcdee requested changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@mcdee mcdee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Various comments . We should also update the version of go-eth2-wallet-types so that it has the correct interface definition.

@Bez625 Bez625 requested a review from mcdee September 12, 2024 15:20
@mcdee
Copy link
Collaborator

mcdee commented Sep 12, 2024

Please can you add a mock for the new function in mock/erroring.go?

@Bez625
Copy link
Contributor Author

Bez625 commented Sep 13, 2024

Please can you add a mock for the new function in mock/erroring.go?

Done

@mcdee mcdee merged commit 28dfce7 into wealdtech:master Sep 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdee mcdee Awaiting requested review from mcdee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bez625 @mcdee