Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add cluster/statistics endpoint handling. #1441

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jfrancoa
Copy link
Contributor

This commit adds a new cluster method get_cluster_statistics() which retrieves valuable statistics from the cluster.

Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (4)

weaviate/cluster/types.py:41

  • [nitpick] The variable name id_ is inconsistent. It should be renamed to id.
id_: str

weaviate/cluster/types.py:75

  • [nitpick] The variable name open_ is inconsistent. It should be renamed to open.
open_: bool

integration_v3/test_cluster.py:139

  • The test checks for 'open' instead of 'open_'. It should be updated to match the naming convention used in the ClusterNodeStats class.
assert isinstance(node["open"], bool)  # API returns 'open', not 'open_'

integration_v3/test_cluster.py:168

  • The test checks for 'id' instead of 'id_'. It should be updated to match the naming convention used in the RaftPeer class.
assert isinstance(peer["id"], str)  # API returns 'id', not 'id_'
@jfrancoa jfrancoa force-pushed the jose/add-cluster-statistics branch from f53be79 to 0f880d8 Compare November 27, 2024 14:24
This commit adds a new cluster method get_cluster_statistics()
which retrieves valuable statistics from the cluster.
@jfrancoa jfrancoa force-pushed the jose/add-cluster-statistics branch from 0f880d8 to c82f2a3 Compare November 27, 2024 14:39
@jfrancoa jfrancoa changed the title Add cluster/statistics endpoint handling. WIP: Add cluster/statistics endpoint handling. Nov 27, 2024
@jfrancoa
Copy link
Contributor Author

I have just realized that the classes I changed are for the v3 version of the client, I will need some more time to rework it.

@weaviate-git-bot
Copy link

Great to see you again! Thanks for the contribution.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants