-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add cluster/statistics endpoint handling. #1441
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orca Security Scan Summary
Status | Check | Issues by priority | |
---|---|---|---|
Passed | Infrastructure as Code | 0 0 0 0 | View in Orca |
Passed | Secrets | 0 0 0 0 | View in Orca |
Passed | Vulnerabilities | 0 0 0 0 | View in Orca |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (4)
weaviate/cluster/types.py:41
- [nitpick] The variable name id_ is inconsistent. It should be renamed to id.
id_: str
weaviate/cluster/types.py:75
- [nitpick] The variable name open_ is inconsistent. It should be renamed to open.
open_: bool
integration_v3/test_cluster.py:139
- The test checks for 'open' instead of 'open_'. It should be updated to match the naming convention used in the ClusterNodeStats class.
assert isinstance(node["open"], bool) # API returns 'open', not 'open_'
integration_v3/test_cluster.py:168
- The test checks for 'id' instead of 'id_'. It should be updated to match the naming convention used in the RaftPeer class.
assert isinstance(peer["id"], str) # API returns 'id', not 'id_'
f53be79
to
0f880d8
Compare
This commit adds a new cluster method get_cluster_statistics() which retrieves valuable statistics from the cluster.
0f880d8
to
c82f2a3
Compare
I have just realized that the classes I changed are for the v3 version of the client, I will need some more time to rework it. |
Great to see you again! Thanks for the contribution. |
This commit adds a new cluster method get_cluster_statistics() which retrieves valuable statistics from the cluster.