Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatibility with remark-directive #1767

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Jan 22, 2025

Summary

Related Issue

close #1766

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 18da50f
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/6790e1698c7f8d0008a97a6e
😎 Deploy Preview https://deploy-preview-1767--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 70 (🔴 down 20 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JounQin
Copy link
Contributor Author

JounQin commented Jan 23, 2025

cc @Timeless0911

Copy link
Contributor

@Timeless0911 Timeless0911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Timeless0911
Copy link
Contributor

Does this issue exist in mdx-rs? I remember there were some parsing issues when facing different indents.

@JounQin
Copy link
Contributor Author

JounQin commented Jan 23, 2025

Does this issue exist in mdx-rs? I remember there were some parsing issues when facing different indents.

I don't think so, this only happens when remark-directive enabled what means mdx-rs is disabled.

@Timeless0911
Copy link
Contributor

No problem. I just remember an issue about mdx-rs, see web-infra-dev/mdx-rs#48.

@Timeless0911 Timeless0911 merged commit b4ae1be into web-infra-dev:main Jan 23, 2025
7 checks passed
@JounQin JounQin deleted the fix/directive branch February 10, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: container-syntax plugin is incompatible with remark-directive
2 participants