Usage treshold & severity levels #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbuerk
reviewed
Sep 26, 2024
pixelbrackets
force-pushed
the
usage-flashmessage-treshold
branch
from
e537b55 to
86ac206
Compare
calien666
force-pushed
the
usage-flashmessage-treshold
branch
2 times, most recently
from
0de018b to
d3d080d
Compare
Refs web-vision#343 [FEATURE] Make translation limits more readable [FEATURE] Follow up: More readable quota in toolbar [FEATURE] Replace severity numbers with constants [FEATURE] Enable color changes for DeepL action icon Action icons dont have a fixed color set, in order to let TYPO3 set the desired color - black in list actions, white in toolbar infos. Change the DeepL SVG to not use black in all places. [FEATURE] Determine severity based on quota usage Calculate the message severity based on the API quota usage rate. Matching popular quota warning levels if will notify above 90% usage, and shown an error when the limit is exceeded. Hide the flashmessage after a translation if the severity is low. Refs web-vision#343 [FEATURE] Make widget more compact and use severity Use severity levels in widget as well and reduce the height to prevent unused whitespace.
calien666
force-pushed
the
usage-flashmessage-treshold
branch
2 times, most recently
from
db44bfa to
0acdc04
Compare
For better maintenance move the severity calculation and number formatting to the UsageService and adjust code.
calien666
force-pushed
the
usage-flashmessage-treshold
branch
from
0acdc04 to
3376892
Compare
sbuerk
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on formating styles in PR #357 and the desire for a threshold in issue #343 I have
tweaked the severity level determination in all usage bars (flashmessage, system infobox, widget).
Based on warning levels in other software (90%, 98%, 100%) each info box will use a different
severity color according to the currently used quota.
The widget is a bit more compact now, since it used a lot of whitespace before,
which makes the dashboard unnecessary large.