Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add developer guide on Arch Linux #310

Merged

Conversation

TimePrinciple
Copy link
Contributor

Modified .env file to better describe the database URL configuration process.

Copy link

vercel bot commented Jan 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mega ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 26, 2024 8:52am

Copy link
Collaborator

@benjamin-747 benjamin-747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments here

.env Outdated
MEGA_DB_MYSQL_URL = "mysql://${MYSQL_USERNAME}:${MYSQL_SECRET}@${MYSQL_HOST}/mega"

# If you followed the installation guide, you can use below URL directly, comment it the otherwise.
MEGA_DB_POSTGRESQL_URL = "postgres://mega:[email protected]/mega"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to display the username and password in plain text? I recommend configuring them in production as environment variables, while using plaintext for local development

.env Outdated

MEGA_OBJ_REMOTE_REGION = "cn-east-3" # Remote cloud storage region
MEGA_OBJ_REMOTE_ENDPOINT = "https://obs.cn-east-3.myhuaweicloud.com" # Override the endpoint URL used for remote storage services
#MEGA_OBJ_REMOTE_REGION = "cn-east-3" # Remote cloud storage region
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 19-20 should not be commented

.env Outdated

MEGA_OBJ_LOCAL_PATH = "/tmp/.mega" # This configuration is used to set the local path of the project storage
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newest default config of MEGA_OBJ_LOCAL_PATH should be "/tmp/.mega/objects"

.env Outdated
GIT_INTERNAL_DECODE_STORAGE_BATCH_SIZE = 10000 # The maximum number of git object in a "INSERT" SQL database operation
GIT_INTERNAL_DECODE_STORAGE_TQUEUE_SIZE = 10 # The maximum number of parallel insertion threads in the database operation queue
GIT_INTERNAL_DECODE_CACHE_TYEP = "lru" #{lru,redis}
GIT_INTERNAL_DECODE_CACHE_SIZE = 100 # Maximum number of git objects in LRU cache
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not recommend to change the default Objects decode configuration

auto-merge was automatically disabled January 25, 2024 12:16

Head branch was pushed to by a user without write access

@benjamin-747
Copy link
Collaborator

Hi @TimePrinciple, It seems commit 6d1fab0 was not signed, you may need to resubmit it

Modified `.env` to dictate users to set up `DB` related fields properly according to their actual setup.

Signed-off-by: Ruoqing He <[email protected]>
auto-merge was automatically disabled January 26, 2024 08:50

Head branch was pushed to by a user without write access

@TimePrinciple TimePrinciple force-pushed the add_arch_development_guide branch from 5868adc to e8d9230 Compare January 26, 2024 08:50
@genedna genedna added this pull request to the merge queue Jan 26, 2024
Merged via the queue into web3infra-foundation:main with commit 022c82e Jan 26, 2024
5 checks passed
@TimePrinciple TimePrinciple deleted the add_arch_development_guide branch January 26, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants