Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CI): cross platform CI for mega and monobean #875

Merged
merged 6 commits into from
Feb 27, 2025

Conversation

yyk808
Copy link
Contributor

@yyk808 yyk808 commented Feb 27, 2025

Major changes

  1. Reconstruct workflow files: base.yml, add reusable action install-dep/action.yml, for handling system dependencies on windows, linux(ubuntu) and macOS.
  2. run cargo fmt --all for mega repository to pass fmt test.

Note

  1. windows-latest runners suffers from extremly slow compression and decompression speed, resulting caching phase take MUCH LONGER time than ubuntu and macos runners. See this blog and issue.
  2. Before this pr, cargo test for mega is quite incomplete, for it only runned 2 tests for mega/mega(module).
  3. Ignoring windows runners, CI on other platforms are faster than ever before. Take clippy on ubuntu for example:
    {5E9D45AA-BFA4-4B39-A478-2637246E455C}
    {D05CE560-26AB-4132-A45A-02A7308AFD2D}
    We got about 2x speed up(21s + 3m21s comparing 24s + 8m21s) for clippy on ubuntu-latest.

Copy link

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mega ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 7:37am

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@genedna genedna enabled auto-merge February 27, 2025 08:19
@genedna genedna added this pull request to the merge queue Feb 27, 2025
Merged via the queue into web3infra-foundation:main with commit e739a77 Feb 27, 2025
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants