GitHub actions #186
Open
GitHub actions #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that, when I created this PR, all github actions run prrety fast and were completely done (including an extra one python 3.11), and the azure ones hadn't even started yet at that moment. |
sdrapha
force-pushed
the
github_actions
branch
from
d0953b7 to
683896a
Compare
sdrapha
force-pushed
the
github_actions
branch
from
683896a to
800b4f6
Compare
sdrapha
force-pushed
the
github_actions
branch
from
dc6e72b to
c0aec04
Compare
cdnninja
suggested changes
Jan 25, 2025
.github/workflows/tests.yml
Outdated
| strategy: | ||
| matrix: | ||
| python-version: | ||
| - '3.8' |
There was a problem hiding this comment.
3.8 fail so should be removed since I think this needs 3.9
|
Outside of tests I am a big fan of pre-commit instead of github actions for linting. It auto corrects items it can in the PRs plus consumes the precommit files that VS code uses so just enforces those same items. https://pre-commit.ci/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if you are interested on github actions, but I did it anyway.
I know there are currently azure-pipelines already there. But the github version of workflows integrates so well both on web interface, app, notifications, etc. so I'm just putting it out there.
It's possible to improve it a bit, breaking out flake8, mypy and pylint in different threads, but for now, just converting the existing azure pipeline structure works well.