Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Github PR title checks #272

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

cdnninja
Copy link
Contributor

@cdnninja cdnninja commented Jan 24, 2025

This starts to move toward this: #271 Let me know if that doesn't interest you.

It checks all PRs to confirm they use semantic titles. This is important as without it the release code can't detect the notes or create the release. Examples being fix: chore: feat: docs:

This will add an item on PRs like this:
image

One setting that I find is important is the merge sittings for PRs to ensure the title is used to squash the commits to a single line. It should be set like this to keep it clean and functional:

image

Once this is merged I can create a PR for the actual release into pypi. You would need to add a token to the repo for the upload, I can't add that token. Nor will I be able to see it as setup as secret in the repo.

@webdjoe
Copy link
Owner

webdjoe commented Jan 24, 2025

This is great, I will move the tests and linting to gh actions as well. Thank you for the PR's!

@cdnninja
Copy link
Contributor Author

Awesome. This one and #273 should get merged first. Ready at anytime. When this one is merged it is worth adjusting merge settings as well.

After that #274 should be done but only after adding the pypi key.

Let me know if you have any questions or want any adjustments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants