-
Notifications
You must be signed in to change notification settings - Fork 48
Passing cucumber-js argument as attachment. #134
base: master
Are you sure you want to change the base?
Passing cucumber-js argument as attachment. #134
Conversation
v.chuchkalov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you copying this patch to v5?
@christian-bromann I am not sure it needs now (until we will have wdio-cucumber-framework v5 port) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase on master. No other issues.
@imdmitrykravchenko Awesome 👍 |
80aedf5
to
436b573
Compare
@christian-bromann yes, I will make same changes for v5 in a few days @BorisOsipov rebased |
Will merge once ported to v5. I know we haven't ported cucumber yet but it would be still great to stay consistent. |
Run tests |
Cucumber argument, fix conflict
fix lint problem
@christian-bromann |
@vchuchkalov as we now support Cucumber v5 we need to ensure that every change that affects the old version is also added upstream to the latest version. Can you please make a similar PR to the Allure reporter in v5? |
@christian-bromann ok, i will do it later. on next week 👍 |
According to webdriverio-boneyard/wdio-cucumber-framework#143