Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(widgets): fetch saved access token automatically #344

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(widgets): fetch saved access token automatically #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c5fa34
feat(widgets): fetch access token automatically
Nov 30, 2024
ebd4149
feat(widgets): remove local changes
Nov 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions demo/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import React, {useState} from 'react';
import { createRoot } from 'react-dom/client';
import React, {useState, useEffect} from 'react';
import {createRoot} from 'react-dom/client';
import {Button, Input, Sidebar, SidebarBody, SidebarNav, SidebarNavItem, Checkbox} from '@momentum-ui/react';

import WebexMeetingsWidgetDemo from './WebexMeetingsWidgetDemo';

import '@momentum-ui/core/css/momentum-ui.min.css';
Expand All @@ -16,21 +15,33 @@ export default function App() {
event.preventDefault();
setTokenInput('');
setToken();
localStorage.removeItem('webexWidgetsDemoAccessToken');
};

const handleUpdateInputToken = (event) => {
setTokenInput(event.target.value);
const saveTokenButton = document.getElementById('saveTokenButtonId');
if (event.target.value.length === 0) saveTokenButton.disabled = true;
else saveTokenButton.disabled = false;
Comment on lines 22 to +25
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Replace direct DOM manipulation with React state.

Direct DOM manipulation with getElementById is an anti-pattern in React. Use state to manage the button's disabled state.

+const [isSaveButtonDisabled, setIsSaveButtonDisabled] = useState(true);
+
 const handleUpdateInputToken = (event) => {
   setTokenInput(event.target.value);
-  const saveTokenButton = document.getElementById('saveTokenButtonId');
-  if (event.target.value.length === 0) saveTokenButton.disabled = true;
-  else saveTokenButton.disabled = false;
+  setIsSaveButtonDisabled(event.target.value.length === 0);
 };

Then update the button props:

-<Button color="blue" type="submit" onClick={handleSaveToken} disabled={!!token} ariaLabel="Save Token">
+<Button color="blue" type="submit" onClick={handleSaveToken} disabled={!!token || isSaveButtonDisabled} ariaLabel="Save Token">

Committable suggestion skipped: line range outside the PR's diff.

};

const handleSaveToken = (event) => {
event.preventDefault();
setToken(tokenInput);
localStorage.setItem('webexWidgetsDemoAccessToken', tokenInput);
};

function handleFedrampChange() {
setFedramp(!fedramp);
}

useEffect(() => {
const savedUserAccessToken = localStorage.getItem('webexWidgetsDemoAccessToken');
if (savedUserAccessToken) {
setTokenInput(savedUserAccessToken);
}
}, []);

return (
<>
<Sidebar withIcons={false}>
Expand Down Expand Up @@ -65,7 +76,6 @@ export default function App() {
name="token"
onChange={handleUpdateInputToken}
placeholder="Access Token"
readOnly={!!token}
type="password"
value={tokenInput}
/>
Expand Down
3 changes: 3 additions & 0 deletions docs/demo.bundle.21d6dc76bb96ca9b5537.js
View file
Open in desktop

Large diffs are not rendered by default.

Loading