New Admin UI - Sidebar #4536
Open
New Admin UI - Sidebar #4536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/storybook |
…into feat/nav # Conflicts: # packages/admin-ui/src/index.ts
|
/storybook |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the new Sidebar component.
It's only a primitive at this point. We'll be integrating it into Admin app via a separate PR.
Extra Changes
1.
IconButton- Support Forimgand Added Shrink StylesBasically, I needed to pass an
imginto theIconButtoncomponent, but its CSS was only applying styles to SVGs. So I've also added same styles that targetimgtag. I also addedshrink-0styles, so that the shrinking of SVG/img is prevented.2.
shrink-0ForIconAdded the same
shrink-0style forIconcomponent.