Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Individual reactions for meetings #4271

Merged
merged 18 commits into from
Nov 22, 2023
Merged

Individual reactions for meetings #4271

merged 18 commits into from
Nov 22, 2023

Conversation

Bestem0r
Copy link
Contributor

@Bestem0r Bestem0r commented Nov 8, 2023

Description

Adds individual reactions to meeting reactions, meaning you can now see who reacted with which emoji! 🎉

Backend PR

Result

Screencast.from.08.nov.2023.kl.15.37.+0100.webm

Testing

  • I have thoroughly tested my changes.
  1. Checkout your backend to the correct branch
  2. Navigate to a meeting.
  3. Verify that adding and removing reactions work.
  4. Verify that the reaction tooltip displays who reacted to the emoji.
  5. Verify that reactions on articles and quotes work like before, but don't display who reacted.

Resolves ABA-571

@Bestem0r Bestem0r added the review-needed Pull requests that need review label Nov 8, 2023
@Bestem0r Bestem0r requested a review from ivarnakken November 8, 2023 14:49
@Bestem0r Bestem0r mentioned this pull request Nov 8, 2023
Merged
ivarnakken
ivarnakken reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

app/components/LegoReactions/index.tsx Outdated Show resolved Hide resolved
app/components/Reactions/Reaction.tsx Outdated Show resolved Hide resolved
app/reducers/reactions.ts Outdated Show resolved Hide resolved
app/reducers/reactions.ts Outdated Show resolved Hide resolved
app/components/Reactions/ReactionPickerContent.tsx Outdated Show resolved Hide resolved
app/components/Reactions/Reaction.tsx Outdated Show resolved Hide resolved
app/components/LegoReactions/index.tsx Outdated Show resolved Hide resolved
app/components/LegoReactions/index.tsx Outdated Show resolved Hide resolved
app/components/LegoReactions/index.tsx Outdated Show resolved Hide resolved
app/actions/ReactionActions.ts Outdated Show resolved Hide resolved
@ivarnakken ivarnakken added new-feature Pull requests that introduce a new feature changes-requested Pull requests with requested changes labels Nov 8, 2023
@Bestem0r Bestem0r requested a review from ivarnakken November 14, 2023 20:37
ivarnakken
ivarnakken approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🏅

@ivarnakken ivarnakken added approved Pull requests that have been approved and removed changes-requested Pull requests with requested changes labels Nov 22, 2023
@ivarnakken ivarnakken merged commit d76f248 into master Nov 22, 2023
2 checks passed
@ivarnakken ivarnakken deleted the individual-reactions branch November 22, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivarnakken ivarnakken ivarnakken approved these changes

Assignees
No one assigned
Labels
approved Pull requests that have been approved new-feature Pull requests that introduce a new feature review-needed Pull requests that need review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bestem0r @ivarnakken