Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug-fix css for eventType name #5281

Merged
merged 1 commit into from
Jan 23, 2025
Merged

bug-fix css for eventType name #5281

merged 1 commit into from
Jan 23, 2025

Conversation

tindevw
Copy link
Contributor

@tindevw tindevw commented Jan 15, 2025 •
edited
Loading

Description

Event Type text and buttons were positioned wrong. Aligned it correctly by changing JustifyComponent to flex-end in the ButtonGroup.

Result

  • Changes look good on both light and dark theme.
  • Changes look good with different viewports (mobile, tablet, etc.).
  • Changes look good with slower Internet connections.

before:
image
image

after:

image
image

Testing

  • I have thoroughly tested my changes.

Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.

Resolves ABA-1230

@tindevw tindevw self-assigned this Jan 15, 2025
@linear Linear
Copy link

linear bot commented Jan 15, 2025

ABA-1230 Event type text is positioned wrong

@vercel Vercel
Copy link

vercel bot commented Jan 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 11:57am

@github-actions github-actions bot added the review-needed Pull requests that need review label Jan 15, 2025
Viljen789
Viljen789 reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@Viljen789 Viljen789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, maybe a small mistake with the extra newline, but the fix is amazing!

@tindevw tindevw force-pushed the event-type-text-issue branch 2 times, most recently from 68c65ee to 3dd08d1 Compare January 15, 2025 21:40
@tindevw tindevw force-pushed the event-type-text-issue branch from bf5e2cb to e5f6cba Compare January 16, 2025 08:05
@tindevw tindevw requested a review from ivarnakken January 16, 2025 09:24
@tindevw tindevw force-pushed the event-type-text-issue branch from 31b28cd to 18fbed3 Compare January 16, 2025 11:27
@tindevw tindevw force-pushed the event-type-text-issue branch from bf9755d to a115335 Compare January 16, 2025 11:50
@tindevw tindevw requested a review from ivarnakken January 16, 2025 11:52
@tindevw tindevw force-pushed the event-type-text-issue branch from efb3c48 to 77a9289 Compare January 16, 2025 11:56
eikhr
eikhr approved these changes Jan 18, 2025
View reviewed changes
Copy link
Member

@eikhr eikhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! :shipit:

falbru
falbru approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@falbru falbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

ShaileshS1702
ShaileshS1702 approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@ShaileshS1702 ShaileshS1702 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

ivarnakken
ivarnakken approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good! 😍 Awesome job!

@ivarnakken ivarnakken added approved Pull requests that have been approved priority:high Pull requests that have high priority, and should therefore be prioritized bug-fix Pull requests that fix a bug labels Jan 23, 2025
@tindevw tindevw merged commit 0588cfa into master Jan 23, 2025
8 checks passed
@tindevw tindevw deleted the event-type-text-issue branch January 23, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Viljen789 Viljen789 Viljen789 left review comments

@ShaileshS1702 ShaileshS1702 ShaileshS1702 approved these changes

@ivarnakken ivarnakken ivarnakken approved these changes

@falbru falbru falbru approved these changes

@eikhr eikhr eikhr approved these changes

@juniwbjerde juniwbjerde Awaiting requested review from juniwbjerde

@Arashfa0301 Arashfa0301 Awaiting requested review from Arashfa0301

@jonasdeluna jonasdeluna Awaiting requested review from jonasdeluna

Assignees

@tindevw tindevw

Labels
approved Pull requests that have been approved bug-fix Pull requests that fix a bug priority:high Pull requests that have high priority, and should therefore be prioritized review-needed Pull requests that need review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tindevw @eikhr @falbru @ivarnakken @Viljen789 @ShaileshS1702