Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emoji search bar to fill the remaining space. #5311

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Viljen789
Copy link
Contributor

Description

Fixed the emoji search bar not completely filling the box

Result

If you've made visual changes, please check the boxes below and include images showing the changes. Descriptions are appreciated.

  • Changes look good on both light and dark theme.
  • Changes look good with different viewports (mobile, tablet, etc.).
  • Changes look good with slower Internet connections.

Caution

Make sure your images do not contain any real user information.




Description Before After

Search bar filling the entire box


image

image

Testing

  • I have thoroughly tested my changes.

Tested light/dark theme and re-scaling the screen.


Resolves ABA-527

Copy link

linear bot commented Jan 29, 2025

Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2025 7:46pm

@github-actions github-actions bot added the review-needed Pull requests that need review label Jan 29, 2025
@Viljen789 Viljen789 requested a review from ivarnakken January 29, 2025 19:32
@Viljen789 Viljen789 added the changes-requested Pull requests with requested changes label Jan 29, 2025
Copy link
Contributor

@falbru falbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

app/components/Reactions/ReactionPickerFooter.module.css Outdated Show resolved Hide resolved
@Viljen789 Viljen789 requested a review from ch0rizo January 29, 2025 19:45
Copy link
Contributor

@ch0rizo ch0rizo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Viljen789 Viljen789 enabled auto-merge January 30, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes-requested Pull requests with requested changes review-needed Pull requests that need review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants