Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: information about prikk #5316

Merged
merged 4 commits into from
Feb 3, 2025
Merged

Add: information about prikk #5316

merged 4 commits into from
Feb 3, 2025

Conversation

ch0rizo
Copy link
Contributor

@ch0rizo ch0rizo commented Jan 31, 2025

Description

Added a information button about "prikk". Just a link to in-depth information about prikk-system (/arrangementsregler). Thought it would be nice to have a shortcut.

Please take a look at my css, I think it may be a bit clumsy. The button currently does not look good in dark mode because its black. What do you think about the placement of the button? Tried to get it next to "Prikker" title, but that was hard, because of profileSection-comp does not allow Icon, i think.

Result

If you've made visual changes, please check the boxes below and include images showing the changes. Descriptions are appreciated.

  • Changes look good on both light and dark theme.
  • Changes look good with different viewports (mobile, tablet, etc.).
  • Changes look good with slower Internet connections.

Caution

Make sure your images do not contain any real user information.

Add information button Screenshot 2025-01-31 at 11 22 25 Screenshot 2025-01-31 at 11 21 55
... ... ...

Testing

  • I have thoroughly tested my changes.

Resolves ABA-1258

@ch0rizo ch0rizo self-assigned this Jan 31, 2025
Copy link

linear bot commented Jan 31, 2025

Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2025 7:40pm

@github-actions github-actions bot added the review-needed Pull requests that need review label Jan 31, 2025
Copy link
Contributor

@Arashfa0301 Arashfa0301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

app/routes/users/components/UserProfile/Penalties.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@falbru falbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@ch0rizo ch0rizo merged commit 0c21c7f into master Feb 3, 2025
8 checks passed
@ch0rizo ch0rizo deleted the feat-information-prikk branch February 3, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-needed Pull requests that need review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants