Fix tests

webkom · Jan 29, 2025 · dc4eda2 · dc4eda2
1 parent 7c7f7ff
commit dc4eda2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/lego/apps/achievements/utils/calculation_utils.py b/lego/apps/achievements/utils/calculation_utils.py
@@ -29,7 +29,8 @@
 
 def calculate_user_rank(user):
     score = 0.0
-
+    if not user.achievements.exists():
+        return 0
     user_achievements = user.achievements.all()
     for achievement in user_achievements:
         rarity_list = ACHIEVEMENT_RARITIES.get(achievement.identifier, [])

diff --git a/lego/apps/users/models.py b/lego/apps/users/models.py
@@ -423,9 +423,12 @@ def delete(self, using=None, force=False):
         super(User, self).delete(using=using, force=force)
 
     def save(self, *args, **kwargs):
-        from lego.apps.achievements.utils.calculation_utils import calculate_user_rank
+        if self.pk:
+            from lego.apps.achievements.utils.calculation_utils import (
+                calculate_user_rank,
+            )
 
-        self.achievements_score = calculate_user_rank(self)
+            self.achievements_score = calculate_user_rank(self)
         super().save(*args, **kwargs)
 
     @property