Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pre-defined choices for company types #3702

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ivarnakken
Copy link
Member

Can be used in filtering on /companies, and to auto-complete the interest form after a company has been selected (the company interest model already uses the same choices).

The text field is not optional in the frontend, so it has not been used that much. I will manually migrate these.

@ivarnakken ivarnakken added review-needed Pull requests that need review small-fix Pull requests that fix something small labels Dec 15, 2024
@ivarnakken ivarnakken requested a review from a team December 15, 2024 14:54
@ivarnakken ivarnakken self-assigned this Dec 15, 2024
Copy link

linear bot commented Dec 15, 2024

Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.60%. Comparing base (c52c6f1) to head (8f45904).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3702   +/-   ##
=======================================
  Coverage   89.60%   89.60%           
=======================================
  Files         700      701    +1     
  Lines       22430    22434    +4     
=======================================
+ Hits        20099    20103    +4     
  Misses       2331     2331           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@norbye norbye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@falbru falbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-needed Pull requests that need review small-fix Pull requests that fix something small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants