Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device selection explainer #784

Merged
merged 15 commits into from
Jan 21, 2025

Conversation

zolkis
Copy link
Collaborator

@zolkis zolkis commented Nov 13, 2024

An initial draft to summarize the discussion.
Feel free to change it in any way, add commits here etc.

The main forums to discuss this are #749 and #759.
After we agree on a solution, this explainer can be archived.

@anssiko should we create an explainers folder?

@anssiko
Copy link
Member

anssiko commented Nov 14, 2024

@zolkis thanks for this explainer! There's no good way to redirect existing explainers, so for consistency you can keep this file in the root. Perhaps explainer-device-selection.md -> device-selection-explainer.md.

@zolkis zolkis force-pushed the device-selection-explainer branch from c401b84 to f45266f Compare December 18, 2024 14:28
@zolkis zolkis changed the title Add device selection explainer (WiP) Add device selection explainer Dec 19, 2024
@zolkis
Copy link
Collaborator Author

zolkis commented Jan 15, 2025

@mwyrzykowski could you please check if this is acceptable for merging, and whether the Minimum Viable Solution in the end is a good first step for making a PR (minus including the "low-latency" option which is a possible future discussion, but not now).

Copy link

@mwyrzykowski mwyrzykowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zolkis for the writeup! Looks good!

device-selection-explainer.md Outdated Show resolved Hide resolved
Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

device-selection-explainer.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for collecting the backstory and previous context links. If it was easy, we would have figured it out long ago, implying it's not easy 😉.

device-selection-explainer.md Outdated Show resolved Hide resolved
device-selection-explainer.md Outdated Show resolved Hide resolved
device-selection-explainer.md Outdated Show resolved Hide resolved
device-selection-explainer.md Outdated Show resolved Hide resolved
device-selection-explainer.md Outdated Show resolved Hide resolved
device-selection-explainer.md Outdated Show resolved Hide resolved
device-selection-explainer.md Outdated Show resolved Hide resolved
device-selection-explainer.md Outdated Show resolved Hide resolved
device-selection-explainer.md Show resolved Hide resolved
device-selection-explainer.md Outdated Show resolved Hide resolved
zolkis and others added 2 commits January 20, 2025 10:19
Corrections from Dwayne

Co-authored-by: Dwayne Robinson <[email protected]>
@zolkis
Copy link
Collaborator Author

zolkis commented Jan 20, 2025

Thanks @fdwr for the suggestions and comments, I have updated the text. Maybe it needs a proofreading before squash-merging.

Copy link
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zolkis: 👍 LGTM.

Waiting on any other input? Otherwise we'll merge it.

@zolkis
Copy link
Collaborator Author

zolkis commented Jan 20, 2025

We agreed on the last call that it could be merged - so go ahead, thanks!

Copy link
Member

@anssiko anssiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a proofreading pass with some suggestions. Also added a "Participate" header.

As discussed on our call https://www.w3.org/2025/01/16-webmachinelearning-minutes.html#f000 this explainer is now ready to be merged.

Thank you @zolkis for putting this explainer together and everyone for your review and suggestions!

As usual, this doc will be updated whenever the group learns more about this topic.

device-selection-explainer.md Outdated Show resolved Hide resolved
device-selection-explainer.md Outdated Show resolved Hide resolved
device-selection-explainer.md Outdated Show resolved Hide resolved
device-selection-explainer.md Outdated Show resolved Hide resolved
device-selection-explainer.md Show resolved Hide resolved
@anssiko anssiko merged commit 17a44e2 into webmachinelearning:main Jan 21, 2025
2 checks passed
@zolkis
Copy link
Collaborator Author

zolkis commented Jan 21, 2025

Thank you Anssi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants