Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back NDK toolchain because of performance issues #96

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

TBSniller
Copy link
Collaborator

Fixes very slow performance on all TVs.
Kind of addresses this issue: #94. But we should not close it yet, because renicing process might be still useful.
Tested on TVs down to webOS 3.4

@smx-smx
Copy link
Contributor

smx-smx commented Sep 30, 2022

As per @throwaway96 analysis, you should explicitly add -mfpu=neon to CFLAGS and/or -DLIBYUV_NEON (which is correctly handled only in the gyp build).

buildroot-nc4 doesn't do that by default because it targets a generic CPU by default (-mcpu and -mtune are not set). Therefore, setting either -mcpu/-mtune is also a viable alternative.

@TBSniller
Copy link
Collaborator Author

As per @throwaway96 analysis, you should explicitly add -mfpu=neon to CFLAGS and/or -DLIBYUV_NEON (which is correctly handled only in the gyp build).

buildroot-nc4 doesn't do that by default because it targets a generic CPU by default (-mcpu and -mtune are not set). Therefore, setting either -mcpu/-mtune is also a viable alternative.

@smx-smx @throwaway96 thanks for analysis and letting me know! will test it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants