sdp: simulcast: Properly parse and set 'a=simulcast:' #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is at least one corresponding pion commit if anyone interested |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #528 +/- ##
==========================================
+ Coverage 61.53% 61.55% +0.01%
==========================================
Files 529 529
Lines 48859 48877 +18
Branches 12367 12369 +2
==========================================
+ Hits 30067 30085 +18
+ Misses 9588 9585 -3
- Partials 9204 9207 +3 ☔ View full report in Codecov by Sentry. |
haaspors
force-pushed
the
simulcast-rid
branch
2 times, most recently
from
7c15348 to
70b297d
Compare
This improves parsing and generation of SDP for simulcast attribute according to RFC8853. Support for alternative formats are not implemented 100%. Comparing to Pion implementation, this commit at least covers more, hopefully most usecases for webrtc-rs users.
haaspors
force-pushed
the
simulcast-rid
branch
from
70b297d to
b989e68
Compare
rainliu
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves parsing and generation of SDP for simulcast attribute according to RFC8853.
Support for alternative formats are not implemented 100%.
Comparing to Pion implementation, this commit at least covers more, hopefully most usecases for webrtc-rs users.