Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simulcast for firefox #534

Merged
merged 3 commits into from
Apr 21, 2024
Merged

Conversation

haaspors
Copy link
Contributor

This is a patchset which at least improves using webrtc-rs on a SFU with simulcast and firefox as a client

I found that the simulcast example didn't work for Firefox. It might not really work now either, but this should be a step on the way.
Please let me know what you think :)

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: Patch coverage is 44.82759% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 61.71%. Comparing base (4e09f92) to head (e8d776f).

Files Patch % Lines
.../rtp_transceiver/rtp_receiver/rtp_receiver_test.rs 44.44% 0 Missing and 10 partials ⚠️
...tc/src/peer_connection/peer_connection_internal.rs 45.45% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #534   +/-   ##
=======================================
  Coverage   61.70%   61.71%           
=======================================
  Files         530      530           
  Lines       48848    48847    -1     
  Branches    12274    12268    -6     
=======================================
+ Hits        30142    30146    +4     
- Misses       9542     9545    +3     
+ Partials     9164     9156    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This fixes RTP receiver from Firefox as it signal SSRCs for all
simulcast layers, while Chromium doesn't which ends up in another code
path.
This ends up tracks being "discovered" via SRTP session accept.
@haaspors haaspors force-pushed the simulcast-firefox branch from 87bd8b6 to e8d776f Compare April 21, 2024 21:42
@haaspors
Copy link
Contributor Author

Ping @rainliu

Please leave some feedback on what you think about this. Thanks!

@rainliu rainliu merged commit 4f6fa13 into webrtc-rs:master Apr 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants