Reduce memory allocations for SDP marshal #596
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I noticed a large number of memory allocations during
marshal
ofSessionDescription
. And I wanna propose implementation offmt::Display
forSessionDescription
struct and some fixesfmt::Display
implementations for sub types acrosssdp
crate. Also, implementation offmt::Display
will allow to writeSessionDescription
into preallocated strings:let mut out = String::with_capacity(1024); write!(out, "{sdp}");
Performance improvement according existed benchmark:
Source
SDP/Marshal time: [11.610 µs 11.621 µs 11.633 µs]
New
SDP/Marshal time: [4.3594 µs 4.3840 µs 4.4143 µs]