Do not greedily inject @ParameterizedTest; instead treat is as explicit param. injection #170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #169
This is one of the options that I thought of as a solution - we will now avoid injecting into such test unless there is an explicit CDI qualifier at any given parameter.
Note that junit is very simple in its approach and always considers the very first arg. to be the parameterized one (or first
n
params if you have more) and there is nothing we can do about that. This means that users can still try to have first param resolved by Weld (by adding qualifier) and have a conflict of multiple extensions competing for that given parameter.The other option I had in mind was simply not injecting into
@ParameterizedTest
at all unless annotated with explicit param injection. I don't mind either, I just thought the one I proposed here is a tad bit user friendlier.