Add support for --updates to mkksiso

[jkonecny12]

It would be great way to avoid requirement for HTTP server for local development.

[coveralls]

Pull Request Test Coverage Report for Build 7732724437

• -4 of 8 (50.0%) changed or added relevant lines in 1 file are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage increased (+0.2%) to 43.665%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/bin/mkksiso	4	8	50.0%

Files with Coverage Reduction	New Missed Lines	%
src/bin/mkksiso	1	63.96%

Totals
Change from base Build 7700282223:	0.2%
Covered Lines:	1621
Relevant Lines:	3507

---

💛 - Coveralls

[bcl]

You should already be able to do this by passing --add /path/to/updates/ which will add the updates/ directory and all of its content to the root of the iso.

Having a dedicated command is slightly nicer of course, but it also skips the CheckBigFiles function.

[jkonecny12]

Yes, I know but it means that you have to document the approach of how to use this command and it's prone to typos. For that reason I think separate option is better and could be promoted as easy way to develop / debug Anaconda.

I'll add the CheckBigFiles support.

[jkonecny12]

Updated to resolve pending issues.

[bcl]

You need to check if updates_img is empty, otherwise you end up with [""] (which the tests caught, woo hoo!)

[jkonecny12]

Should be fixed. Feel free to say if you don't like to have this kind of expression. I like it but might be harder to read for someone.

[bcl]

I usually like those, but I think having it as an argument to a function call makes the function it harder to read. Even just moving it up and giving it a new variable:

check_paths = add_paths if not updates_image else add_paths + [updates_image]
if CheckBigFiles(check_paths):

is easier, I think.

[bcl]

I tweaked the CheckBigFiles call and rewrote the commit message to be a bit clearer about what this does and merged it locally.
Thanks!