Only show controls for things with an image service #11515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +6 B (0%) Total Size: 1.02 MB
ℹ️ View Unchanged
|
davidpmccormick
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
For #11513
It only makes sense to show the rotation and zoom controls for items that have an image service. They shouldn't show when display the audio/video players or pdfs.
How to test
Make sure the extendedViewer toggle is turned on
Visit http://localhost:3000/works/enye955g/items
The controls for rotation and zoom should appear when each canvas is scrolled to
Visit:
http://localhost:3000/works/yycbn2r4/items (pdf)
http://localhost:3000/works/tp9njewm/items (audio)
http://localhost:3000/works/qvgcmea3/items (born digital)
http://localhost:3000/works/fhy2fv5k/items (video)
The controls for rotation and zoom should not appear
How can we measure success?
Redundant controls aren't displayed
Have we considered potential risks?
The controls don't show when they should.