TriggerSim updates for larsoft v10 #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trigger into jierans/daq_triggeralgs_v10
…trigger into jierans/daq_triggeralgs_v10
- Previously all TPs on the same channel are thrown out except for the first one that makes a match. Stop doing this and let all TPs be saved in the TA window - Save maximum TOT in the TA as "time_activity" - Do not throw away all TPs once one adjancency TA is formed. Instead, keep all TPs irrelevant to the adjacency so that they can form TA with new TPs after window rotation. Fix TA initialization
JamesJieranShen
force-pushed
the
jierans/daq_triggeralgs_v10
branch
from
c7898f0 to
b67f75e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Larsoft v10 replaces the geometry service with the WireReadout class to perform channel mapping. This requires changes to module code. However this merging this will break larsoft v9.xx installs. Some unnecessary instantiations of the geom service also needs to be removed as it causes unused-variable warnings when compile (and since larsoft by default builds with -WError).
Since we are targeting v10 for eventual publishing with other dunesw repos, this should be merged when convenient.