对课表页面的初步构造 #14
Merged
对课表页面的初步构造 #14
+3,135
−1,980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4c9d5bd.
|
备忘一下，突然想起来时间冲突课程的去重还没做。 |
renbaoshuo
commented
Feb 5, 2025
renbaoshuo
commented
Feb 5, 2025
| @@ -150,9 +151,9 @@ const CoursePage: React.FC<CoursePageProps> = ({ config, locateDateResult, semes | |||
| headerLeft: () => <Text className="ml-4 text-2xl font-medium">课程表</Text>, | |||
| // eslint-disable-next-line react/no-unstable-nested-components | |||
| headerTitle: () => ( | |||
| <Pressable onPress={() => toast.info('周数切换')} className="flex flex-row items-center"> | |||
| <Pressable onPress={() => setShowWeekSelector(!showWeekSelector)} className="flex flex-row items-center"> | |||
There was a problem hiding this comment.
Suggested change
| <Pressable onPress={() => setShowWeekSelector(!showWeekSelector)} className="flex flex-row items-center"> | |
| <Pressable onPress={() => setShowWeekSelector(prev => !prev)} className="flex flex-row items-center"> |
renbaoshuo
commented
Feb 5, 2025
components/course/course-page.tsx
Outdated
Comment on lines
155
to
156
| <AntDesign name="caretdown" size={10} color="black" /> | ||
| <AntDesign name={showWeekSelector ? 'caretup' : 'caretdown'} size={10} color="black" /> |
There was a problem hiding this comment.
统一用 IonIcons 吧，减少封包体积，这玩意没有 tree-shaking。
It has already implemented in west2-online/jwch@0f62759
|
提议：这个 PR 体积较大，建议使用 merge commit 来 merge 到主分支中，而不是使用 squash and merge，以便后人 git blame。 |
|
这个 PR 由于过于庞大，涉及到的变更过多，目前我们考量是先合入主仓库，后续对剩余特性单独开 PR 解决。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3.
这个 PR 由于过于庞大，涉及到的变更过多，目前我们考量是先合入主仓库，后续对剩余特性单独开 PR 解决。
已解决
待解决