Accessibility assessment of content page #2332
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ouafaaetta
force-pushed
the
a11y-content-page
branch
from
1330aa9 to
0bb81a8
Compare
ouafaaetta
changed the title
duboisp
requested changes
May 25, 2024
| "earl:test": "WCAG21:info-and-relationships", | ||
| "earl:subject": "_:subject", | ||
| "earl:outcome": "earl:failed", | ||
| "dct:description": "Attached screen capture: Error P883 - SC 1.3.1, Nest heading properly. Heading elements must be ordered properly.", |
There was a problem hiding this comment.
Add the text version of the image.
But wait a minute, is this description that is wrong or the attached image? Or is there 2 attachments?
The attached image say "Missing value for 'content' attribute. If either 'name', 'http-equiv', 'property', or 'itemprop' is specified, then the 'content' attribute must have a value
Comment on lines
618
to
619
| { | ||
| "acr:asset": { |
There was a problem hiding this comment.
This attachment is just floating, I think it goes into the _:sc_4.1.2
Set at the description the text in the image which is : Missing value for 'content' attribute. If either 'name', 'http-equiv', 'property', or 'itemprop' is specified, then the 'content' attribute must have a value
Apply the suggested changes from the comments Co-authored-by: Pierre Dubois <[email protected]>
added the requested changes in the comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change is a continuation of PR2305