-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WET-boew -> GCWeb ->Simple example pages #2409
base: master
Are you sure you want to change the base?
Conversation
ad6ebf4
to
76841d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Fix the URLs to the example pages for Navcurrent and Resize (make sure the language toggle also works)
- Remove the class "list-inline" from the list of events and list of components. It is not necessary
28c96b1
to
d3ae51a
Compare
Made the changes @Garneauma |
Pre-approved upon successful review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Rename folder "navcurrent" to "wb-navcurr"
- Rename folder "resize" to "wb-rsz"
- Address inline comments
- Rebase PR to fix merge conflict
<ul> | ||
<li><a class="btn btn-primary" href="https://github.com/wet-boew/GCWeb/issues/new?title=Ajax%20Fetch">Questions or comments?</a></li> | ||
</ul> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe this is necessary as they are not actual plugins. Do this for all your examples.
<ul> | |
<li><a class="btn btn-primary" href="https://github.com/wet-boew/GCWeb/issues/new?title=Ajax%20Fetch">Questions or comments?</a></li> | |
</ul> |
Simple example pages with corresponding component references for the following components:
ajax-fetch
json-fetch
navcurrent
resize
wb-focus
Also a minor fix for the geomap index.json-ld file where an english example page had a language value of "fr"