-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empathy Thematic - Improve CSS for Card Pattern #2445
Open
BrahimMahadi
wants to merge
2
commits into
wet-boew:master
Choose a base branch
from
BrahimMahadi:empathy
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrahimMahadi
temporarily deployed
to
github-ci
November 12, 2024 17:08 — with
GitHub Actions
Inactive
Pre-approved upon successful review. |
Garneauma
requested changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the requested changes. Please include in the meta.md
the following:
- Clear and simple explanations of the new feature, change or update;
- The impact on the sponsored department of the new feature, change or update;
- The impact on the public of the new feature, change or update.
You can refer to the "changes
" property in the meta.md
file of 2024-10-datatable-utilities
.
duboisp
requested changes
Nov 21, 2024
duboisp
reviewed
Nov 21, 2024
BrahimMahadi
temporarily deployed
to
github-ci
December 9, 2024 20:06 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following pull request was made to address CSS styles that have been injected to the landing page of the What to do when someone dies section using the Multi-Media component instead of having these styles added to the existing Empathy theme.
General checklist