Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empathy Thematic - Improve CSS for Card Pattern #2445

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BrahimMahadi
Copy link
Contributor

The following pull request was made to address CSS styles that have been injected to the landing page of the What to do when someone dies section using the Multi-Media component instead of having these styles added to the existing Empathy theme.

General checklist

  • Implementation of the injected CSS classes to the existing Empathy theme.
  • Tested and ensured styles are properly implemented.
  • Adjusted documentation to reflect new classes
  • Reference JIRA ticket WET-493

@Garneauma
Copy link
Contributor

Pre-approved upon successful review.

@Garneauma Garneauma self-assigned this Nov 18, 2024
@Garneauma Garneauma self-requested a review November 18, 2024 15:30
Copy link
Contributor

@Garneauma Garneauma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the requested changes. Please include in the meta.md the following:

  • Clear and simple explanations of the new feature, change or update;
  • The impact on the sponsored department of the new feature, change or update;
  • The impact on the public of the new feature, change or update.

You can refer to the "changes" property in the meta.md file of 2024-10-datatable-utilities.

méli-mélo/th-empathy/empathy.html Outdated Show resolved Hide resolved
méli-mélo/th-empathy/empathy.html Outdated Show resolved Hide resolved
méli-mélo/th-empathy/empathy.html Show resolved Hide resolved
méli-mélo/th-empathy/empathy.html Outdated Show resolved Hide resolved
méli-mélo/th-empathy/style.css Show resolved Hide resolved
méli-mélo/th-empathy/empathy.html Outdated Show resolved Hide resolved
méli-mélo/th-empathy/empathy.html Outdated Show resolved Hide resolved
méli-mélo/th-empathy/empathy.html Outdated Show resolved Hide resolved
méli-mélo/th-empathy/empathy.html Outdated Show resolved Hide resolved
méli-mélo/th-empathy/style.css Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants